-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Adds ability to set alternate local folder for config/metadata directory #109
Conversation
This way, the retrieval does not fail when running with a Python interpreter that is not a `venv` like virtual environment. Co-authored-by: Catherine Fait <[email protected]>
Config directory is specified in config_setup.yml at the project root so that alternate local config/metadata dir can be found
✅ Deploy Preview for em27-retrieval-pipeline ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@dostuffthatmatters do you have any comments on this? |
This is a great idea! Thank you. We actually just started a second metadata repository because one of our measurement campaigns produced so much metadata. I would prefer if one passes the alternative config directory via the command line instead of a separate What do you think? |
@dostuffthatmatters I tested the fix for pressure null values #107 and its working. I will rebase this to the latest updates. |
@cfleur great that it works now! Agreed. Command line arguments might be messy because you also have to add it to every single CLI command/call. Environment variables is a good way of doing it. |
Closing as PR #111 opened instead from different branch. |
WIP!
Closes #108
Based on v1.3.2 due to problems running retrievals on v1.4.0 (see #107).
Config directory is specified in config_setup.yml.
Includes cherry pick of Use sys.executable instead of .venv/bin/python to run retrievals