Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a planar pcs system with pneumatic actuation #5

Merged
merged 14 commits into from
Nov 22, 2024

Conversation

mstoelzle
Copy link
Contributor

No description provided.

@mstoelzle mstoelzle requested a review from Copilot November 22, 2024 23:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 suggestion.

Comments skipped due to low confidence (3)

src/jsrm/systems/planar_pcs.py:259

  • [nitpick] The default implementation of actuation_mapping_fn assumes a fully actuated and identity actuation matrix, which might be too simplistic for some use cases. Consider providing a more flexible default implementation.
A = B_xi.T @ jnp.identity(n_xi) @ B_xi

src/jsrm/systems/planar_pcs.py:441

  • The kinetic_energy_fn function is now called with an additional parameter q. Ensure that the function signature matches the new call.
T = kinetic_energy_fn(params, q, q_d)

src/jsrm/systems/pneumatic_planar_pcs.py:39

  • The new actuation_mapping_fn function introduces new behavior that should be covered by tests. Ensure that the actuation matrix is correctly computed and applied.
def actuation_mapping_fn(

src/jsrm/systems/pneumatic_planar_pcs.py Outdated Show resolved Hide resolved
@mstoelzle mstoelzle merged commit 4ec9302 into main Nov 22, 2024
24 checks passed
@mstoelzle mstoelzle deleted the feature/pneumatic-planar-pcs branch November 22, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant