Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify how to find StarkGate bridge and token addresses in block explorers #1241

Merged
merged 2 commits into from
May 7, 2024

Conversation

stoobie
Copy link
Collaborator

@stoobie stoobie commented May 1, 2024

Description of the Changes

Readers repeatedly ask for the addresses for StarkGate bridge and supported tokens. This PR clarifies how to find the json files that include that information.

PR Preview URL

Bridged tokens
Supported tokens and token addresses in StarkGate

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@stoobie stoobie requested a review from natan-granit May 1, 2024 11:12
Copy link

github-actions bot commented May 1, 2024

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1241/documentation/ .

1 similar comment
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1241/documentation/ .

Copy link
Collaborator

@natan-granit natan-granit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have another section in the overview that is specific for StarkGate addresses.
It should have the same information as in the table currently in the StarkGate tokens sections. It should be the first section.

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1241/documentation/ .

3 similar comments
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1241/documentation/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1241/documentation/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1241/documentation/ .

Copy link
Collaborator

@natan-granit natan-granit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1241/documentation/ .

@stoobie stoobie merged commit fa62138 into main May 7, 2024
1 check passed
@stoobie stoobie deleted the steve/starkgate/clarify_addresses branch May 7, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants