-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: [StarkGate] Add procedures for Depositing and Withdrawing. #1236
Conversation
…dded URL to starknet-docs-antora-ui project in GitHub.
…ge address, with xref to page with pointer to addresses.
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1236/documentation/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments:
- In the case of initiate withdrawal, we should change back to the function that includes the token as a parameter.
- Lets add an bridge addresses section in the overview, before the tokens.
- Would be nice to have an example with a block explorer also in smart deposit.
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1236/documentation/ . |
Wiil do.
See #1241
Let's make this a separate PR so as to expedite this one without delay. WDYT? |
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1236/documentation/ . |
2 similar comments
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1236/documentation/ . |
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1236/documentation/ . |
…dded URL to starknet-docs-antora-ui project in GitHub.
…ge address, with xref to page with pointer to addresses.
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1236/documentation/ . |
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1236/documentation/ . |
Oops, your pull request failed to pass the Typo tests stage :( . see the result: Please fix the typo, commit and push! |
1 similar comment
Oops, your pull request failed to pass the Typo tests stage :( . see the result: Please fix the typo, commit and push! |
5aca145
to
fd31263
Compare
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1236/documentation/ . |
0aa8061
to
da3681c
Compare
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1236/documentation/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of the Changes
This PR adds procedures for Depositing and Withdrawing using StarkGate with a block explorer.
PR Preview URL
Depositing funds
Withdrawing funds
Check List
<docs/feat/fix/chore>(optional scope): <description>
, e.g:fix: minor typos in code
This change is