-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate CA secret to new namespace #476
Conversation
56ed99b
to
08b6614
Compare
08b6614
to
bf66f2c
Compare
deploy/helm/secret-operator/templates/secret_migration_job.yaml
Outdated
Show resolved
Hide resolved
deploy/helm/secret-operator/templates/secret_migration_job.yaml
Outdated
Show resolved
Hide resolved
deploy/helm/secret-operator/templates/secret_migration_job.yaml
Outdated
Show resolved
Hide resolved
deploy/helm/secret-operator/templates/secret_migration_job.yaml
Outdated
Show resolved
Hide resolved
deploy/helm/secret-operator/templates/secret_migration_job.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
Co-authored-by: Natalie Klestrup Röijezon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on the shellcheck
pass, and the described testing (in the team call).
I now created separate RBAC rules for the Job now instead of using the ones from secret-operator. Reasoning (besides better security): Just retested it a couple of times, works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Fixes #453 by creating a one-time job that copies the secret over to the new namespace if it does not exist there yet.
Definition of Done Checklist
Author
Reviewer
Acceptance