Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Always use the 24.7.0 version of the tools image because testing PR artifacts breaks otherwise #480

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

dervoeti
Copy link
Member

@dervoeti dervoeti commented Jul 23, 2024

This fixes testing of PR versions of secret-operator since the testruns got broken by #476

We stumbed across this:

When I run a custom test with secret-operator I’m allowed to choose a PR-Version like secret=0.0.0-pr455 which then in the secret-migration Job causes the image being docker.stackable.tech/stackable/tools:1.0.0-stackable0.0.0-pr455 which is a consequence of the image selection mechanism.

Since the tools image does not have PR artifacts that relate to the PRs in secret-operator we now specify a fixed version so that testing PRs works again. Currently it fails because the according tools image is not present.
We're using 24.7.0 because it's multiarch. It's manually built for now to make this work and will get rebuilt by the release process later.

Copy link
Contributor

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

the fix I needed, thank you! :)

We can merged it's checked by the release team and we gonna include it.

@Maleware Maleware added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 4f0925a Jul 23, 2024
31 checks passed
@Maleware Maleware deleted the fix/migrate-job-tools-image-release-version branch July 23, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants