Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sharing GenericConversionService between test methods #31291

Closed
wants to merge 1 commit into from
Closed

Stop sharing GenericConversionService between test methods #31291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...src/test/java/org/springframework/core/convert/support/GenericConversionServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import java.util.Map;
import java.util.Set;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;

import org.springframework.core.convert.ConversionFailedException;
Expand Down Expand Up @@ -61,11 +62,16 @@
* @author Phillip Webb
* @author David Haraburda
* @author Sam Brannen
* @author Yanming Zhou
*/
class GenericConversionServiceTests {

private final GenericConversionService conversionService = new GenericConversionService();
private GenericConversionService conversionService;

@BeforeEach
void init() {
conversionService = new GenericConversionService();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test class uses JUnit Jupiter with the default @TestInstance lifecycle mode which is PER_METHOD, meaning that the test instance will be instantiated for each test method.

Consequently, the GenericConversionService will be recreated for every instance/test.


@Test
void canConvert() {
Expand Down