Stop sharing GenericConversionService between test methods
#31291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests called mutating methods like addConverterFactory(), it will potentially affect other tests.
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
reviewed
Sep 22, 2023
| @BeforeEach | ||
| void init() { | ||
| conversionService = new GenericConversionService(); | ||
| } |
There was a problem hiding this comment.
This test class uses JUnit Jupiter with the default @TestInstance lifecycle mode which is PER_METHOD, meaning that the test instance will be instantiated for each test method.
Consequently, the GenericConversionService will be recreated for every instance/test.
|
Closing as "works as designed". See #31291 (review). |
sbrannen
added
status: invalid
sbrannen
changed the title
GenericConversionService between test methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests called mutating methods like
addConverterFactory(), it will potentially affect other tests.