Add support for SPDX Spec Version 3 #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: changes are not complete - this commit includes code that breaks the compilation. This is just an intermediate checking to save progress
Signed-off-by: Gary O'Neall <[email protected]>
|
As an update - the changes to the SPDX Java Library have been merged into the master branch. |
It seems that jsonschemafriend is no longer available in Maven Central so we need to add the jitpack repository - needed for the Integration Tests
Since we're not initializing or using the default model store, we need to always pass in a model store to the license expression parser methods. Note that not using the default avoids a potential memory issue for long running Maven scripts.
Cleaning up formatting - my IDE now has the Maven coding style added for this project, so it should be a bit cleaner going forward.
|
@hboutemy - This should now be ready for review. The libraries this new version depends on have been published so it should be a lot easier to test. I also just finished cleaning up the code and making sure all the integration tests and unit tests pass. Any review comments are very much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170
This is a rather large PR with some refactoring involved. For a description, see this comment.
This PR is currently in draft due to dependencies on some enhancements in the SPDX Java Library required for a successful compilation. These changes have been merged into the master branch of the java library but have not been released or published to Maven Central (reference spdx/Spdx-Java-Library#262)
To include this fix, you can pull down the latest code from the SPDX Java Library and build the dependency.
There is also a fix in the spdx-java-rdf-store which is required to pass the unit tests. This has been merged into the main - so you can pull down the latest from the project.
The code changes passes unit tests, but the integration tests are currently failing and a SonarCloud analysis has not been run - so there are likely some code cleanup issues to be found.