You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SPDX Spec version 3.0 is a major upgrade with breaking changes.
The SPDX Java Library has been updated to support spec version 3.0 - also causing some breaking changes.
Since the object model is structurally different, there will have to be significant changes to this plugin if we want to support both 3.0 and previous versions of the spec.
I would propose making the following changes:
Add a new supported SPDX format "jsonld" which would result in building SPDX Spec version 3 documents
Remove all SPDX model class references from the CreateSpdxMojo class as well as all classes in the org.spdx.maven package. This would localize all the model references to the org.spdx.maven.util package.
Create abstract classes for the util builder classes (e.g. SpdxDocumentBuilder) and 2 concrete subclasses - one for the currently supported spec versions and a separate one for the SPDX spec version 3 support. This removes a lot of namespace conflicts and simplifies the logic (e.g. not having a lot of if/else in the individual methods) at the expense of some code duplication. Note: I experimented with modifying the same class and found the code to be way to messy.
Update the existing enums in the utils package to support both the SPDX Spec version 2 and SPDX Spec version 3 model enumerations.
The text was updated successfully, but these errors were encountered:
@goneall it looks reasonable: I'll try to find this this WE to review what is available and help as much as possible
Thanks @hboutemy - I just created a draft PR #171 with the changes. Note it depends on some changes in the SPDX Java Library to compile and some changes in the SPDX Java RDF store to pass the unit tests. Details are in the PR comments.
SPDX Spec version 3.0 is a major upgrade with breaking changes.
The SPDX Java Library has been updated to support spec version 3.0 - also causing some breaking changes.
Since the object model is structurally different, there will have to be significant changes to this plugin if we want to support both 3.0 and previous versions of the spec.
I would propose making the following changes:
CreateSpdxMojo
class as well as all classes in theorg.spdx.maven
package. This would localize all the model references to theorg.spdx.maven.util
package.SpdxDocumentBuilder
) and 2 concrete subclasses - one for the currently supported spec versions and a separate one for the SPDX spec version 3 support. This removes a lot of namespace conflicts and simplifies the logic (e.g. not having a lot of if/else in the individual methods) at the expense of some code duplication. Note: I experimented with modifying the same class and found the code to be way to messy.The text was updated successfully, but these errors were encountered: