Add PoST Service API #268
Merged
Add PoST Service API #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
reviewed
Sep 19, 2023
lrettig
reviewed
Sep 19, 2023
fasmat
force-pushed
the
add-post-service-api
branch
from
39e7d7f to
e3c1db1
Compare
|
@poszu if you agree I would like to merge the current API as is. The initial implementation seems to work well and we can keep iterating on it in the future. With the API released we can merge spacemeshos/post-rs#133, release that version and integrate it into the node. wdyt? |
4 tasks
poszu
approved these changes
Oct 18, 2023
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 19, 2023
## Motivation Closes #5131 do not merge before spacemeshos/api#268 and spacemeshos/post#245 ## Changes - setup for gRPC servers has been moved from node startup into the `grpcserver` package - `NewPublic`, `NewPrivate` and `NewTLS` create servers for the given purposes based on the configuration passed to them - replaced more instances of `go-spacemesh/log` with `zap` ## Test Plan - existing tests pass - TODO: add new tests for mTLS connection ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Oct 19, 2023
## Motivation Closes #5131 do not merge before spacemeshos/api#268 and spacemeshos/post#245 ## Changes - setup for gRPC servers has been moved from node startup into the `grpcserver` package - `NewPublic`, `NewPrivate` and `NewTLS` create servers for the given purposes based on the configuration passed to them - replaced more instances of `go-spacemesh/log` with `zap` ## Test Plan - existing tests pass - TODO: add new tests for mTLS connection ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #269