[Merged by Bors] - Add mTLS grpcserver #5154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5154 +/- ##
=========================================
- Coverage 77.8% 77.6% -0.2%
=========================================
Files 259 260 +1
Lines 30773 30960 +187
=========================================
+ Hits 23944 24047 +103
- Misses 5342 5409 +67
- Partials 1487 1504 +17
|
fasmat
force-pushed
the
5131-add-authenticated-listener
branch
from
28a0716 to
10d28f1
Compare
poszu
reviewed
Oct 15, 2023
fasmat
force-pushed
the
5131-add-authenticated-listener
branch
from
5995f25 to
76c8334
Compare
poszu
approved these changes
Oct 18, 2023
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
## Motivation Closes #5131 do not merge before spacemeshos/api#268 and spacemeshos/post#245 ## Changes - setup for gRPC servers has been moved from node startup into the `grpcserver` package - `NewPublic`, `NewPrivate` and `NewTLS` create servers for the given purposes based on the configuration passed to them - replaced more instances of `go-spacemesh/log` with `zap` ## Test Plan - existing tests pass - TODO: add new tests for mTLS connection ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
Build failed:
|
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
## Motivation Closes #5131 do not merge before spacemeshos/api#268 and spacemeshos/post#245 ## Changes - setup for gRPC servers has been moved from node startup into the `grpcserver` package - `NewPublic`, `NewPrivate` and `NewTLS` create servers for the given purposes based on the configuration passed to them - replaced more instances of `go-spacemesh/log` with `zap` ## Test Plan - existing tests pass - TODO: add new tests for mTLS connection ## TODO <!-- This section should be removed when all items are complete --> - [x] Explain motivation or link existing issue(s) - [x] Test changes and document test plan - [x] Update documentation as needed - [x] Update [changelog](../CHANGELOG.md) as needed
|
bors merge |
|
Already running a review |
|
Pull request successfully merged into develop. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5131
do not merge before spacemeshos/api#268 and spacemeshos/post#245
Changes
grpcserverpackageNewPublic,NewPrivateandNewTLScreate servers for the given purposes based on the configuration passed to themgo-spacemesh/logwithzapTest Plan
TODO