Fix SMPTE 291 exactframerate field #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o/raw, audio/L, video/smpte291 and video/SMPTE2022-6
(Thanks to @cmaberto, Cameron Maberto, Apple, for the original bug report.)
|
New unit tests found another simple bug so I've fixed that too 🤦♂️ |
Although this revision should have been published in 2022 and the SSN should have been updated to match, neither of those things actually happened... Co-authored-by: jonathan-r-thorpe <[email protected]>
|
@jonathan-r-thorpe I believe this is now failing just because #351 isn't merged yet... so I guess the proper procedure is to merge #351 into master, then merge master into this PR branch, check the CI results and then merge this to master. Sigh. |
|
Agreed - tested #351 against the updated (but not merged SDPoker) and that is failing because |
|
Verified with the updated SDPoker. LGTM |
This was referenced Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests + basically same fix for #344 as proposed by @cmaberto in #345.