Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exact Frame Rate SDP Field for SMPTE 291 SDP Generation #344

Closed
cmaberto opened this issue Sep 19, 2023 · 2 comments
Closed

Exact Frame Rate SDP Field for SMPTE 291 SDP Generation #344

cmaberto opened this issue Sep 19, 2023 · 2 comments

Comments

@cmaberto
Copy link

Seems like the exactframerate SDP field is not correctly written. Seems like the if statement for checking for exactframerate is incorrect in make_video_smpte291_sdp_parameters. Removing the not seemed to have fixed me issues with it, unless I am using the functions wrong for 2110-40 SDP creation.

@garethsb
Copy link
Contributor

Thank you, @cmaberto, your fix is good. The exactframerate is already added correctly for video/raw but the not is wrong in the code for video/smpte291 here:

if (!params.exactframerate) fmtp.push_back({ sdp::fields::exactframerate, nmos::details::make_exactframerate(params.exactframerate) });

SDP test cases should be increased for ST 2110-40.

@jonathan-r-thorpe
Copy link
Contributor

Resolved by #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants