-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Em-nesting, alignment-nesting, greek arithmetic numbering #1913
Em-nesting, alignment-nesting, greek arithmetic numbering #1913
Conversation
But i'm not strongly attached to it either. It makes things simpler when one would nest various alignments, but that's kind of an edge case anyway. |
A cursory glance suggests I'll be up for most of this. I targeted it for v0.15.0 since I'd like to resolve especially the inputter changes by then as well as bathing as many breaking changes as we can without making migration too hard. If we cherry-pick some and not other bits that's fine too, but lets try to sort out yes now/no never/maybe later answers on breaking changes sooner rather than later. |
I cherry picked the obvious wins of the inputter touchup and Greek numbering (with a couple new tests) to develop directly, that should leave just the intertwined margin/nesting stuff for this PR. |
BREAKING CHANGE: The former implementation of the "em" command did not support nesting and was just setting the font style to italic. The command now alternates italic and regular when nested.
7d714c9
to
c91d9a7
Compare
BREAKING CHANGE: The "center", "raggedleft" and "raggedright" environments formerly reset the margins (left or right skips), meaning they'd take the full frame width. They all cancelled the paragraph indent. The new behaviour honors the fixed part of the parent context's margins, meaning that if you have an environment playing with margins such as an epigraph or an indented quote, those margins are not lost. The raggedleft and raggedright environment also now no longer cancel the pararagraph indent.
The plain class now provides a "blockquote" environment for indented (and possibly nested) quotations.
The command being now proposed in the plain class, align the example code with it (i.e. keep the stretchability of the nesting context)
…ified environment
…lex-fixes-develop
I think we'll move ahead with the current breaking change that does not cancel Obviously the retrograde shim will not be expected to also support nested use cases the way the new code does, just cover the very basic case of a single level usage and simulate the old behavior. This will probably mean either stashing a private setting, having some private hook, or registering a wrapper/replacement function. |
73d09f6
to
958353e
Compare
958353e
to
4f291da
Compare
4f291da
to
139e47d
Compare
Proposed features from silex.sile - precisely, the subset from silex.fixes
Motivated by #1866
\em
(Does SILE (intend to) support nesting\em
? #1048) - breakingcenter
,raggedright
andraggedleft
+ the latter two no longer cancelling paragraph indent1 - breakingEach topic is a separate commit, with detailed commit logs/
Still to do if we agree on the solution:
Footnotes
This is a bold move, but the two things are somewhat orthogonal here, and parindent-cancellation is doable by other means. ↩