-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the Markdown scenarios #1866
Comments
@Omikhleia Just a heads up one of the big hindrances for me in adopting / recommending Given that I've started using the I think we need to reconsider bringing Markdown parsing back into SILE's core without introducing too many new dependencies. I realize the libraries we ripped out were a good riddance, but I'd like to get |
As for dependencies: without tables, language support and smart quotes, proper super sub- and superscript, I am not sure how it can be achieved with SILE's (current) core without losing functionality... I'm certainly willing to discuss it, but it's not an obvious topic. Perhaps we could have an open discussion on our Gitter (even privately if needed first), at least to consider possible strategies? Also note that markdown.sile goes beyond "mere" Markdown, with Djot etc.
Some things from silex.sile could be sorted out and ported here upstream. I had to move "fast" to be able to make book(s), but there would be a way for some features.
Of course, I don't think this is a good move -- I'm sure we can do better than reviving that old broken/limited solution. |
BTW, unless I missed something, the only required "hard dependency" in markdown.sile on silex.sile are
|
Of course I'm missing the current dependencies...
There's nothing impossible here ;) |
Sorry if that came out wrong, I wasn't blaming you for the way you went about things. I've had to move fast and fix things downstream for my own production work too, I know how it goes. Yes we can talk this over. I'm moving this week so any comments I drop will be a bit spastic. My only intent was to give you a heads up that I was reconsidering v0.15.0 shipping with no level of Markdown inputer support. |
No problem - and you might indeed have to do so, depending on your target release date for 0.15. I am just pointing that there's nevertheless a way forward for removing the dependency on silex.sile from markdown.sile and its dependencies:
As I wrote, it doesn't seem impossible or inaccessible. Then on the other side, I'd need to make a new (major) release of these components, without the silex dependency and officially supporting 0.15 (and possibly also fixing things for Lua 5.1 as per Omikhleia/markdown.sile#101), and doing tests do ensure we are not missing anything (abstracting various hacks to silex.sile was a difficult decision, but at least it means my other components are not that cluttered with them). So there's a bit of a chicken and egg situation, but it all seems doable with a few well-planned iterations... ... #1641 is probably the toughest point - the draft PR is kind of a workaround - but we could also try to address the minimal need and open new tickets for refactors we could address separately later (= such as deciding if some stuff eventually needs to be moved in cldr, splitting hyphenation patterns and better refactoring i18n, etc.). |
A few months later... With markdown.sile 1.5.2 + silex.sile 0.4.1, the latter no longer aggressively "takes over core SILE stuff" (i.e. excepted the bare minimum: language override for BCP47 support and AST utilities). The whole of silex's replacements is now only loaded when using my resilient classes. This addresses one of the point raised here. A possible negative impact of the change is that the multiple package instantiation model introduced in SILE 0.13-0.14 may cause some havoc in some workflows not using a resilient class. One can't make an omelette without breaking eggs. |
Now that the "silex" issue is solved, out of the three check-boxes on this issue
|
And then I am wondering what I meant here, lol! -- but before I forget again, here it is:
In both cases, the issue at stakes is how to embed Markdown/Djot in another (e.g. say SIL) document, where we know from the surrounding context whether we need to support inline elements only (e.g. in the course of a paragraph) or block elements (on their own paragraphs). Footnotes
|
This issue = Sept. 12, 2023 Regarding markdown.sile as 3rd-party collection:
I still don't have any idea what this issue is about or what would be expected here, to plan ahead ;) |
Per #1610 closing a bunch of Markdown related issues I think we have some documentation updates to do. I'd like to
markdown.sile
into this GitHub org as semi-official.The text was updated successfully, but these errors were encountered: