Enforce alphabetically ordered cargo deps #6678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
commented
Dec 11, 2024
macladson
added
ready-for-review
|
I share the annoyance, enforcing sorting sounds good to me |
michaelsproul
approved these changes
Dec 19, 2024
michaelsproul
added
ready-for-merge
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b2b1faa |
This was referenced Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is merely cosmetic, but something that has annoyed me for a while is that dependencies are arbitrarily ordered in every crate which makes it difficult to see at a glace whether a certain dependency is in a crate.
Add
cargo-sortto CI to enforce that dependencies are alphabetically ordered.Additional Changes
This will require devs to order dependencies from now on (or run
cargo sort --workspace).