Enforce alphabetically ordered cargo deps #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mac L <[email protected]>
| @@ -192,3 +192,18 @@ jobs: | |||
| # cache-target: release | |||
| # - name: Run Makefile to trigger the bash script | |||
| # run: make cli | |||
| cargo-sort: | |||
There was a problem hiding this comment.
What do you think about moving this job and the check-code to a new workflow as they are more about code quality than testing?
There was a problem hiding this comment.
Don't really have an opinion on that. @magick93, what do you think?
There was a problem hiding this comment.
IMO splitting it wont add too much value, though I'm happy to do it.
The best value - in the case of test and code qual. comes from giving rapid feedback to the dev. It its not too computationally intensive maybe a pre-commit hook may be better.
There was a problem hiding this comment.
good comment diego, let's merge for now but as workflows become more refined we can revisit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shamelessly stolen from @macladson's PR here: sigp/lighthouse#6678