Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permalinks without .html suffix and fix deprecated config option. #60

Closed
wants to merge 12 commits into from

Conversation

JesseHerrick
Copy link
Contributor

Just a small fix, but I've never liked .html in my permalinks. I've also changed name from the default to Shoes and pygments: true to highlighter: pygments.

@JesseHerrick
Copy link
Contributor Author

This is kind of a part of #52. Also, here are the new routes:

/downloads.html => /downloads/
/tutorials.html => /tutorials/
/blog.html => /blog/
/contribute.html => /contribute/
/about.html => /about/
/get_help.html => /help/

@jasonrclark
Copy link
Member

Definitely like using the non-.html style for the links. 👍 on that!

This looks like the PR pulled in a lot of other CSS changes beyond your description. Was that intended?

Haven't read through all of them in detail but I'm betting a few conflict with the Bootstap+FontAwesome PR @nathancarnes put up on #59 (which I was considering getting merged fairly soon). Any thoughts on how best to proceed there?

@JesseHerrick
Copy link
Contributor Author

Oh, my bad @jasonrclark. I've been working away at the new design. I only meant to PR bcf4102. The design changes I made are not ready.

@JesseHerrick
Copy link
Contributor Author

I'm going to close this PR, cherry pick the proper changes into a new branch and then PR again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants