-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Bootstrap to 3.2.0; FontAwesome to 4.1.0 #59
Conversation
Closes #13, as well. |
Don't personally have a strong opinion on self-hosting vs CDN, so I'm good with this unless someone else has objects. Haven't spotted any differences or problems which would stop me from taking this, but did note that #60 which just came through might have some conflicts with this. Will hang on until we discuss what to do there with @JesseHerrick. Thanks for your work on getting shoesrb.com up to date! 💖 |
I'm completely getting rid of Bootstrap (but not Font Awesome) in #52, @nathancarnes unless you have a compelling reason otherwise. |
@jasonrclark looks like it might conflict with #51, too, although I'm guessing rebasing that branch off of this one would be pretty easy. @JesseHerrick I've got no particular love for Bootstrap. The only compelling reasons to keep it (or any other CSS framework, doesn't need to be Bootstrap) would be to make future updates easier for any maintainers that are less experienced with front-end dev/CSS, and to help enforce consistent styles throughout the site. Both of those concerns are really easily addressed with a one-page style guide, though. :) |
@nathancarnes I had not thought of making a style guide, but I'll be happy to do it once the design is complete. As for the merge conflict, I'll see if I can rebase it here. |
Never mind, there's no easy way to merge the two. |
Thanks for the update and tidying @nathancarnes, and thanks @JesseHerrick for looking into #51. As far as the future, I also don't particularly care whether we keep Bootstrap or not, so please feel free to follow your instincts there. A short style-guide for the less front-end aware (such as myself!) would be awesome! |
Notes