_rotate_kms_key: SkipPerIssues raises AttributeError as self.params object has no attribute 'scylla_version'
#9134
Comments
I think it is related to this part of the logic: https://github.com/scylladb/scylla-cluster-tests/blame/24d72b4466b557fb7920b415208e1a1faa0d6074/sdcm/cluster.py#L4013
Yes, if SKipPerIssue is not needed anymore, it can be removed. But SkipPerIssue still may get dictionary again in other cases. |
As per discussion, this clause can be removed as the ticket is resolved and doesn't have sct skip label (what could have made it being skipped). At the same, it led to unexpected failures when self.params appeared to be dict type instance instead of SCTConfiguration as expected. refs: - scylladb#9134
As per discussion, this clause can be removed as the ticket is resolved and doesn't have sct skip label (what could have made it being skipped). At the same, it led to unexpected failures when self.params appeared to be dict type instance instead of SCTConfiguration as expected. refs: - #9134
As per discussion, this clause can be removed as the ticket is resolved and doesn't have sct skip label (what could have made it being skipped). At the same, it led to unexpected failures when self.params appeared to be dict type instance instead of SCTConfiguration as expected. refs: - #9134 (cherry picked from commit b9708e8)
As per discussion, this clause can be removed as the ticket is resolved and doesn't have sct skip label (what could have made it being skipped). At the same, it led to unexpected failures when self.params appeared to be dict type instance instead of SCTConfiguration as expected. refs: - #9134 (cherry picked from commit b9708e8)
As per discussion, this clause can be removed as the ticket is resolved and doesn't have sct skip label (what could have made it being skipped). At the same, it led to unexpected failures when self.params appeared to be dict type instance instead of SCTConfiguration as expected. refs: - #9134 (cherry picked from commit b9708e8)
As per discussion, this clause can be removed as the ticket is resolved and doesn't have sct skip label (what could have made it being skipped). At the same, it led to unexpected failures when self.params appeared to be dict type instance instead of SCTConfiguration as expected. refs: - #9134 (cherry picked from commit b9708e8)
As per discussion, this clause can be removed as the ticket is resolved and doesn't have sct skip label (what could have made it being skipped). At the same, it led to unexpected failures when self.params appeared to be dict type instance instead of SCTConfiguration as expected. refs: - #9134 (cherry picked from commit b9708e8)
As per discussion, this clause can be removed as the ticket is resolved and doesn't have sct skip label (what could have made it being skipped). At the same, it led to unexpected failures when self.params appeared to be dict type instance instead of SCTConfiguration as expected. refs: - #9134 (cherry picked from commit b9708e8)
|
#9160 fixes the issue, i.e. get it out of the way |
Here is a traceback of failure:
Argus: https://argus.scylladb.com/tests/scylla-cluster-tests/439869f1-5f7a-4840-b6ef-ad1f83ec465e
The issue is in this particular code:
I suppose during the time the test waits to proceed with rotation the object
self.paramsreferences to might have been changed somewhere else.In general, this
if SkipPerIssuesclause can be completely removed since the issue it linked to is closed and doesn't have skip label.@vponomaryov Please, let me know what do you think?
If you don't mind removing this
ifclause, I can remove it. Just decided to raise this question, since thisself.paramsissue may exist somewhere else.The text was updated successfully, but these errors were encountered: