Skip to content

Commit

Permalink
fix(_rotate_kms_key): remove SkipPerIssues since the ticket is resolved
Browse files Browse the repository at this point in the history
As per discussion, this clause can be removed as the ticket is resolved
and doesn't have sct skip label (what could have made it being skipped).
At the same, it led to unexpected failures when self.params appeared to
be dict type instance instead of SCTConfiguration as expected.

refs:
- #9134

(cherry picked from commit b9708e8)
  • Loading branch information
mikliapko authored and fruch committed Nov 10, 2024
1 parent c6cf783 commit 9438a5d
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions sdcm/cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -4430,9 +4430,6 @@ def _rotate_kms_key(kms_key_alias_name, kms_key_rotation_interval, db_cluster):
AwsKmsEvent(
message=f"Failed to rotate AWS KMS key for the '{kms_key_alias_name}' alias",
traceback=traceback.format_exc()).publish()
if SkipPerIssues("https://github.com/scylladb/scylla-enterprise/issues/3896", self.params):
self.log.warning("KMS encryption check is skipped due to the 'scylla-enterprise/issues/3896'")
continue
try:
nemesis_class = self.nemesis[0] if self.nemesis else getattr(
import_module('sdcm.nemesis'), "Nemesis")
Expand Down

0 comments on commit 9438a5d

Please sign in to comment.