fix(_rotate_kms_key): remove SkipPerIssues since the ticket is resolved #9153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per discussion, this clause can be removed as the ticket is resolved and doesn't have sct skip label (what could have made it being skipped). At the same, it led to unexpected failures when self.params appeared to be dict type instance instead of SCTConfiguration as expected. refs: - scylladb#9134
mikliapko
added
backport/2023.1
|
yes we can remove this code, but I would suggest going to the root cause of why params argument wasn't set creating the cluster, we shouldn't let it happen. |
|
I think the actual fix was suppose to be: |
Yes, totally agree with you and I raised a bug about it (#9134) that remains open. |
okay, but still it looks like this peace of code I'm removing is not relevant anymore since the original issue is closed and not labeled as |
roydahan
approved these changes
Nov 7, 2024
This was referenced Nov 7, 2024
Merged
Merged
scylladbbot
added
backport/2024.2-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #9134, this clause can be removed as the ticket is resolved and doesn't have sct skip label (what could have made it being skipped). At the same, it led to unexpected failures when self.params appeared to be dict type instance instead of SCTConfiguration as expected.
Testing
PR pre-checks (self review)
backportlabels