-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix atlas handling and transform file issues in bundle_seg
#80
base: main
Are you sure you want to change the base?
Conversation
…fore downloading atlas
We should discuss what to do with the transform files as output from the registration scripts. As shown here, we might need to access only one of the two transformation files from the output channel. I'm not sure this is the best way to do it, because
I think we should separate the output files in individual channels. From my experience, this also facilitates the pipeline/subworkflows creation process. What do you think @AlexVCaron, @ThoumyreStanislas, @arnaudbore, @Manonedde ? |
bundle_seg
bundle_seg
Go for it ! I do agree it will make things easier. We implemented it that way to facilitate chaining transforms and prevent errors, but it just makes things harder and obscure. |
I've updated the registration scripts @AlexVCaron. However, I struggle to update the snap of |
I'm on that ! |
@rerun-checks |
When we changed how to provide a local copy of the
bundle_seg
atlas, we did not modify the path where the subworkflow fetches the files.We don't have test data to include in the test suite, but I did try it locally, and everything runs smoothly.