-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New module] Freesurfer registration/convert #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, all functionalities are there ! There is a little work to be done on syntax. To be consistent, you should stick with a naming convention. Either use affine
or linear
everywhere when you are talking about the affine/linear part, and drop init
when talking about the input or output transforms.
Once adressed, LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG
Great job @anroy1 ! LGTM 🚀 |
Describe your changes
Add the synthbet option to preproc_t1Warp conversion module - designed initially to convert freesurfer registration warp (affine and deform) to ants-itk. Then decided to generalize the module for all cases possible. Receives one affine matrix, one deform warp, source and target images for orientation (and freesurfer licence) and outputs converted affine and deform.
List test packages used by your module
freeurfer.zip
freesurfer_relice.zip
freesurfer_transforms.zip
Checklist before requesting a review
./modules/nf-scil/<category>/<tool>/main.nf
./modules/nf-scil/<category>/<tool>/meta.yml
./tests/modules/nf-scil/<category>/<tool>/main.nf
./tests/modules/nf-scil/<category>/<tool>/nextflow.config
To Do