Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New module] Freesurfer synthregistration #7

Merged
merged 12 commits into from
Oct 2, 2024

Conversation

anroy1
Copy link
Contributor

@anroy1 anroy1 commented Sep 24, 2024

Describe your changes

Initial module PR for registration tool using Freesurfer synthmorph

Say which test data are used by your module

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

@anroy1 anroy1 changed the title [Module] Freesurfer synthregistration [New module] Freesurfer synthregistration Sep 24, 2024
@AlexVCaron AlexVCaron requested review from AlexVCaron and GuillaumeTh and removed request for Manonedde and gagnonanthony September 24, 2024 18:23
Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, great work ! Syntax and wording, then merge is on !

@anroy1 anroy1 force-pushed the synthregistration branch 2 times, most recently from 242c7f0 to cc7c8af Compare September 26, 2024 20:04
@AlexVCaron AlexVCaron added this pull request to the merge queue Oct 2, 2024
Merged via the queue into scilus:main with commit 8ac6fc4 Oct 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants