Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix features on wasm-bindgen-msrv crate #4345

Closed
wants to merge 1 commit into from
Closed

Fix features on wasm-bindgen-msrv crate #4345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions crates/msrv/lib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@ publish = false
version = "0.0.0"

[features]
default = ["std"]
std = [
"wasm-bindgen/std",
"js-sys/std",
"wasm-bindgen-futures/std",
"web-sys/std",
"wasm-bindgen-test/std",
default = [
"wasm-bindgen/default",
"js-sys/default",
"wasm-bindgen-futures/default",
"web-sys/default",
"wasm-bindgen-test/default",
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't replace the std feature, that's still needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it? I did a simple text search and couldn't find it being used anywhere.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not used because it was under default before. If we intend to add more features (msrv) we have to test these separately, in which case it will be used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, if you want to, we can merge this as-is and re-add the std crate feature in #4278. Let me know how you want to proceed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please do that? I have no idea how to set that up properly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it in e1d2358.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


[dependencies]
Expand Down
13 changes: 6 additions & 7 deletions crates/msrv/resolver/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,12 @@ resolver = "1"
version = "0.0.0"

[features]
default = ["std"]
std = [
"wasm-bindgen/std",
"js-sys/std",
"wasm-bindgen-futures/std",
"web-sys/std",
"wasm-bindgen-test/std",
default = [
"wasm-bindgen/default",
"js-sys/default",
"wasm-bindgen-futures/default",
"web-sys/default",
"wasm-bindgen-test/default",
]

[dependencies]
Expand Down
Loading