Fix features on wasm-bindgen-msrv crate
#4345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
requested changes
Dec 8, 2024
| "js-sys/default", | ||
| "wasm-bindgen-futures/default", | ||
| "web-sys/default", | ||
| "wasm-bindgen-test/default", | ||
| ] |
There was a problem hiding this comment.
Don't replace the std feature, that's still needed.
There was a problem hiding this comment.
Is it? I did a simple text search and couldn't find it being used anywhere.
There was a problem hiding this comment.
Its not used because it was under default before. If we intend to add more features (msrv) we have to test these separately, in which case it will be used.
There was a problem hiding this comment.
Or, if you want to, we can merge this as-is and re-add the std crate feature in #4278. Let me know how you want to proceed.
There was a problem hiding this comment.
Could you please do that? I have no idea how to set that up properly.
|
Closing in favor of #4278. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the change requested here. I made this its own PR, because this is a fix for the misconfigured features of the
msrvcrate and has nothing to do with marker traits.