Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dav1d version to 1.4 #105

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Bump dav1d version to 1.4 #105

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72a1e2a
Bump dav1d version to 1.4
haixuanTao Nov 1, 2024
46e0771
Bump dav1d to version 1.5, and explicit version bound in README
haixuanTao Nov 1, 2024
aa43cf8
Putting a warning that it might not work above 1.5
haixuanTao Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/dav1d.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
DAV1D_DIR: dav1d_dir
LIB_PATH: lib/x86_64-linux-gnu
run: |
git clone --branch 1.3.0 --depth 1 https://code.videolan.org/videolan/dav1d.git
git clone --branch 1.5.0 --depth 1 https://code.videolan.org/videolan/dav1d.git
cd dav1d
meson build -Dprefix=$HOME/$DAV1D_DIR -Denable_tools=false -Denable_examples=false --buildtype release
ninja -C build
Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:

- name: Build dav1d
run: |
git clone --branch 1.3.0 --depth 1 https://code.videolan.org/videolan/dav1d.git
git clone --branch 1.5.0 --depth 1 https://code.videolan.org/videolan/dav1d.git
cd dav1d
meson build -Dprefix=C:\build -Denable_tools=false -Denable_examples=false --buildtype release
ninja -C build
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ steps above.

## Supported versions

The bindings require dav1d 1.3.0
The bindings require dav1d>=1.3.0,<=1.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't know the upper bound really. It might still work with 1.6.0, dav1d is not very consistent with mapping breaking API changes to version numbers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i'm going to write as a warning. My 1.3 version did not work with dav1d 1.4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did it fail?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I can't reproduce anymore, but something along the line of system deps failing with 1.4.1.

I think that documenting as ( might not work ) would be the best documentation as there is no guarantee that it might still work.


## TODO
- [x] Simple bindings
Expand Down
2 changes: 1 addition & 1 deletion dav1d-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ mod build {
use std::process::{Command, Stdio};

const REPO: &str = "https://code.videolan.org/videolan/dav1d.git";
const TAG: &str = "1.3.0";
const TAG: &str = "1.5.0";

macro_rules! runner {
($cmd:expr, $($arg:expr),*) => {
Expand Down
Loading