-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dav1d version to 1.4
#105
Conversation
You can also just bump to 1.5.0 directly here. There are no API changes at all (neither backwards compatible nor breaking ones). |
I have bumped to 1.5. Thanks for the quick review. |
README.md
Outdated
@@ -41,7 +41,7 @@ steps above. | |||
|
|||
## Supported versions | |||
|
|||
The bindings require dav1d 1.3.0 | |||
The bindings require dav1d>=1.3.0,<=1.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't know the upper bound really. It might still work with 1.6.0, dav1d is not very consistent with mapping breaking API changes to version numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, i'm going to write as a warning. My 1.3 version did not work with dav1d 1.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did it fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I can't reproduce anymore, but something along the line of system deps failing with 1.4.1
.
I think that documenting as ( might not work ) would be the best documentation as there is no guarantee that it might still work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lu-zero ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me.
Note that the latest version of dav1d is 1.5 but is not yet present in all package manager.