Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goal updater for CI #4558

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix goal updater for CI #4558

merged 1 commit into from
Jul 25, 2024

Conversation

SteveMacenski
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...avior_tree/plugins/decorator/goal_updater_node.cpp 100.00% <100.00%> (+21.73%) ⬆️

... and 3 files with indirect coverage changes

@SteveMacenski
Copy link
Member Author

@clalancette should I go ahead and merge this or do you want me to hold off for an rclcpp discussion?

@clalancette
Copy link
Contributor

@clalancette should I go ahead and merge this or do you want me to hold off for an rclcpp discussion?

So I think what we should do here is to open an issue against rclcpp with all of the data we currently have (a self-contained reproducer would be ideal, but not required). Once that issue is open, I would then go ahead and merge this workaround for now.

@SteveMacenski Does that make sense to you? Do you mind doing that?

@SteveMacenski
Copy link
Member Author

@clalancette done: ros2/rclcpp#2589

I would like to merge this however to get our CI green, but its easy enough to revert for testing the failure case as part of the development for a fix

@SteveMacenski SteveMacenski merged commit 4516a6a into main Jul 25, 2024
11 checks passed
@SteveMacenski SteveMacenski deleted the housekeeping branch July 25, 2024 17:46
VladyslavHrynchak200204 pushed a commit to logivations/navigation2 that referenced this pull request Jul 30, 2024
VladyslavHrynchak200204 pushed a commit to logivations/navigation2 that referenced this pull request Jul 30, 2024
Signed-off-by: Vladyslav Hrynchak <[email protected]>
@tonynajjar
Copy link
Contributor

tonynajjar commented Dec 4, 2024

@SteveMacenski I noticed that this was not backported to Jazzy branch. I triggered it

mergify bot pushed a commit that referenced this pull request Dec 4, 2024
(cherry picked from commit 4516a6a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants