-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix goal updater for CI #4558
Fix goal updater for CI #4558
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
@clalancette should I go ahead and merge this or do you want me to hold off for an rclcpp discussion? |
So I think what we should do here is to open an issue against rclcpp with all of the data we currently have (a self-contained reproducer would be ideal, but not required). Once that issue is open, I would then go ahead and merge this workaround for now. @SteveMacenski Does that make sense to you? Do you mind doing that? |
@clalancette done: ros2/rclcpp#2589 I would like to merge this however to get our CI green, but its easy enough to revert for testing the failure case as part of the development for a fix |
Signed-off-by: Vladyslav Hrynchak <[email protected]>
@SteveMacenski I noticed that this was not backported to Jazzy branch. I triggered it |
No description provided.