V1 Improved node deposit and node stake-rpl flow

[thomaspanf]

Included in this PR:

• New suggested RPL stake options in stake-rpl, because changing node.per.minipool.stake.minimum to 0 broke the old selection

Please choose an amount of RPL to stake:
1: 5% of borrowed ETH (276.648996 RPL) for one minipool?
2: 10% of borrowed ETH (553.297992 RPL) for one minipool?
3: 15% of borrowed ETH (829.946988 RPL) for one minipool?

• Reintroduced the -y and -a flags to node deposit for users who automate minipool deposits (10/10 foresight)

• node deposit and create-vacant-minipool uses a y/n confirmation rather than prompting for a selection:

// New
NOTE: You are about to make an 8 ETH deposit.
Would you like to continue? [y/n]
y

// Old
Please choose an amount of ETH to deposit:
1: 8 ETH
1

[jshufro]

Allow percents but make the user pass -a 5% instead of -a 5, otherwise it's a POLA violation when someone passes -a 5 and it stakes 5% instead of 5 RPL

[thomaspanf]

Allow percents but make the user pass -a 5% instead of -a 5, otherwise it's a POLA violation when someone passes -a 5 and it stakes 5% instead of 5 RPL

TIL what a POLA violation is. Nice catch, thank you Patches!

[jshufro]

Can we drop the magic values and just use strings.EndsWith(c.String("amount"), "%") to determine if a percentage was passed? Then parse it and the actual amount.

[thomaspanf]

Good call. The latest commit allows for custom percentages passed through as CLI flags and additionally as an option within the command.

[jshufro]

i feel like amount for a deposit is not a float. it's either 8 or 16, in practice

[jshufro]

Let's fold this into "A custom amount"...

Again, just tell the user to either enter an amount of rpl or a precentage of borrowed eth, and check if there's a % suffix

[jshufro]

this is fine but just for edification purposes, fmt.Sscanf may be more semantic, ie https://go.dev/play/p/BVofq8L4EpC

[jshufro]

Thanks for tightening this up! Looks good now.

[thomaspanf]

Thanks for tightening this up! Looks good now.

Always a pleasure, thanks for the review!