Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 Saturn 0 changes + node deposit and stake-rpl updates #704

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

thomaspanf
Copy link
Member

This PR includes changes from #681 and #694

In summary:

  • Removed 16ETH options
  • Removed some node status text that isn't needed in Saturn 0
  • Updated messages and workflow for node deposit (Saturn 0 message, smoothing pool check, 8 eth deposit hardcoded, --a and --y flags still available)
  • Removed stale node stake-rpl options now that node.per.minipool.stake.minimum == 0
  • Replaced those options with 5,10, or 15% borrowed ETH as RPL as well as custom percentage inputs passed within the command or as a CLI flag.

Copy link

Coverage Report

Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/node 0.01% (-0.00%) 👎
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/network 0.00% (ø)
github.com/rocket-pool/smartnode/v2/shared/types/api 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/node/commands.go 0.11% (-0.01%) 876 (+54) 1 875 (+54) 👎
github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/node/deposit.go 0.00% (ø) 1526 (+99) 0 1526 (+99)
github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/node/stake-rpl.go 0.00% (ø) 796 (+180) 0 796 (+180)
github.com/rocket-pool/smartnode/v2/rocketpool-cli/commands/node/status.go 0.00% (ø) 1379 (-151) 0 1379 (-151)
github.com/rocket-pool/smartnode/v2/rocketpool-daemon/api/network/rpl-price.go 0.00% (ø) 179 (-126) 0 179 (-126)
github.com/rocket-pool/smartnode/v2/shared/types/api/network.go 0.00% (ø) 167 0 167

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@0xfornax 0xfornax merged commit 0729581 into v2 Nov 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants