chore: copy plan marks when applying merge group #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvmcastro
force-pushed
the
copy-merged-task-plan-marks
branch
from
7ef8122 to
ce99010
Compare
2 tasks
doudou
reviewed
Dec 6, 2024
wvmcastro
force-pushed
the
copy-merged-task-plan-marks
branch
2 times, most recently
from
94b4661 to
f78ca1d
Compare
This became a necessity as we pretend to do early deployments at network generation. In this scenario, when a "free" task context is merged into its deployed counter part its plan marks is not carried out to the deployment task instance. Then, this task instance would be garbage collected because it did not carried the permanent mark from the replace "free" task context
wvmcastro
force-pushed
the
copy-merged-task-plan-marks
branch
from
f78ca1d to
4edb33a
Compare
doudou
reviewed
Dec 19, 2024
| @solver = Syskit::NetworkGeneration::MergeSolver.new(@local_plan) | ||
| end | ||
|
|
||
| # I don't like the "destination task" name but couldn't thought in a better one |
There was a problem hiding this comment.
Better make that a comment in the PR itself. ... now you have to remove it :P
doudou
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
This became a necessity as we pretend to do early deployments at network generation. In this scenario, when a "free" task context is merged into its deployed counter part its plan marks is not carried out to the deployment task instance. Then, this task instance would be garbage collected because it did not carried the permanent mark from the replace "free" task context
https://buildbot.tidewise.io/#/builders/1791/builds/7