chore: propage permanent mark to task instance generated from deployment #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvmcastro
force-pushed
the
propagate-permanent-mark-to-deployment-task
branch
from
d66ce2d to
f54e3e2
Compare
wvmcastro
changed the title
wvmcastro
force-pushed
the
propagate-permanent-mark-to-deployment-task
branch
from
f54e3e2 to
0dbb1f5
Compare
…loyment It is not strictly needed since the deployment task instance is added to the plan after generation. But as we pretend to do early deployment at generation the garbage collection would throw away tasks contexts that got merged into this instances
wvmcastro
force-pushed
the
propagate-permanent-mark-to-deployment-task
branch
from
0dbb1f5 to
3b0d88c
Compare
|
Not really the right way to go, replace for #443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not strictly needed since the deployment task instance is added to the plan after generation. But as we pretend to do early deployment at generation, the garbage collection would throw away tasks contexts that got merged into this instances.