Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass YCM_USE_CMAKE_NEXT set to OFF in normal-build (i.e. apt with gha image and vcpkg on windows) workflow and bump YCM to v0.16.5 #1672

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Jul 13, 2024

Historically, ycm-cmake-modules have been carrying on a patched version of CMake's ExternalProject module that made sure that it was never possible for ExternalProject to delete a source directory of a repo (the one contained in robotology-superbuild/src/<package>) if one had local modifications and it did not set YCM_EP_DEVEL_MODE_<package> to ON . For more details, see:

Unfortunately, the modification was never merged upstream, and it is not anymore possible for me to keep the forked ExternalProject version aligned with the CMake's upstream ExternalProject. So in this PR we set YCM_USE_CMAKE_NEXT to OFF to stop using YCM's ExternalProject module, and start using the regular CMake's ExternalProject for apt builds on Ubuntu 20.04 . Eventually we will propagate this change by making YCM_USE_CMAKE_NEXT set to OFF by default.

Fix #1671 .

Important

With YCM_USE_CMAKE_NEXT set to ON, the robotology-superbuild raised an error if you called make update-all or ninja update-all and there was repo with local modification with YCM_EP_DEVEL_MODE_<package> set to OFF. By setting YCM_USE_CMAKE_NEXT to OFF, instead the robotology-superbuild will discard the local modifications. To avoid losing data, never call the update-all target if you have local modifications in a package and you did not set YCM_EP_DEVEL_MODE_<package> to ON for that package.

@traversaro traversaro changed the title Pass YCM_USE_CMAKE_NEXT set to OFF in normal-build (i.e. apt with gha image and vcpkg on windows) workflow Pass YCM_USE_CMAKE_NEXT set to OFF in normal-build (i.e. apt with gha image and vcpkg on windows) workflow and bump YCM to v0.16.5 Jul 13, 2024
@traversaro traversaro merged commit 50b755a into master Jul 16, 2024
24 of 25 checks passed
@traversaro traversaro deleted the fix1671 branch July 16, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 20.04 GitHub Actions CI with apt dependencies on GHA images (not vanilla docker) fails
1 participant