-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ci): introduce meta backend agnostic e2e tests #19568
Merged
+75
−193
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
60223c2
demo matrix
BugenZhao 70931db
specify sql endpoint
BugenZhao 8bc9610
test again
BugenZhao 31132df
try hack
BugenZhao 891c82f
set env for docker compose
BugenZhao bea6dda
try try
BugenZhao 499d2af
remove test env
BugenZhao f75ff6c
remove initialization step from script
BugenZhao ff49f95
add sqlite
BugenZhao 3506ae8
all in `env` backend
BugenZhao f8cdc01
unify 3 backends in main-cron
BugenZhao 2759d95
rename pr to other sql backend
BugenZhao e7828e0
try try yaml merge
BugenZhao 7397340
correctly merge envs
BugenZhao c01bd91
migrate pull request workflow as well
BugenZhao 6f02e68
add info log for resolving env
BugenZhao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,37 @@ auto-retry: &auto-retry | |
- signal_reason: agent_stop | ||
limit: 3 | ||
|
||
sql-backend: &sql-backend | ||
matrix: | ||
setup: | ||
backend: [""] | ||
endpoint: [""] | ||
adjustments: | ||
- with: | ||
backend: "" | ||
endpoint: "" | ||
skip: true # hack | ||
- with: | ||
backend: "sqlite" | ||
# sqlite3 /tmp/rwmeta.db | ||
endpoint: "sqlite:///tmp/rwmeta.db?mode=rwc" | ||
- with: | ||
backend: "postgres" | ||
# PGPASSWORD=postgres psql -h db -p 5432 -U postgres -d rwmeta | ||
endpoint: "postgres://postgres:postgres@db:5432/rwmeta" | ||
- with: | ||
backend: "mysql" | ||
# mysql -h mysql -P 3306 -u root -p123456 -D rwmeta | ||
endpoint: "mysql://root:123456@mysql:3306/rwmeta" | ||
env: | ||
RISEDEV_SQL_ENDPOINT: "{{matrix.endpoint}}" | ||
|
||
docker-compose-common: &docker-compose-common | ||
config: ci/docker-compose.yml | ||
mount-buildkite-agent: true | ||
propagate-environment: true | ||
run: rw-build-env | ||
|
||
steps: | ||
- label: "build" | ||
command: "ci/scripts/build.sh -p ci-release" | ||
|
@@ -62,8 +93,9 @@ steps: | |
timeout_in_minutes: 10 | ||
retry: *auto-retry | ||
|
||
- label: "end-to-end test (release)" | ||
- label: "end-to-end test (release, {{matrix.backend}} backend)" | ||
key: "e2e-test-release" | ||
<<: *sql-backend | ||
command: "ci/scripts/cron-e2e-test.sh -p ci-release -m ci-3streaming-2serving-3fe" | ||
if: | | ||
!(build.pull_request.labels includes "ci/main-cron/run-selected") && build.env("CI_STEPS") == null | ||
|
@@ -75,11 +107,10 @@ steps: | |
- "docslt" | ||
plugins: | ||
- docker-compose#v5.1.0: | ||
run: rw-build-env | ||
config: ci/docker-compose.yml | ||
mount-buildkite-agent: true | ||
<<: *docker-compose-common | ||
run: pg-mysql-backend-test-env | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can override the entry in |
||
- ./ci/plugins/upload-failure-logs | ||
timeout_in_minutes: 25 | ||
timeout_in_minutes: 30 | ||
retry: *auto-retry | ||
|
||
- label: "slow end-to-end test (release)" | ||
|
@@ -716,55 +747,15 @@ steps: | |
- "build" | ||
- "build-other" | ||
- "docslt" | ||
plugins: | ||
- docker-compose#v4.9.0: | ||
run: rw-build-env | ||
config: ci/docker-compose.yml | ||
mount-buildkite-agent: true | ||
- ./ci/plugins/upload-failure-logs | ||
timeout_in_minutes: 25 | ||
retry: *auto-retry | ||
|
||
- label: "end-to-end test (postgres backend)" | ||
key: e2e-test-postgres-backend | ||
command: "ci/scripts/e2e-test.sh -p ci-release -m ci-3streaming-2serving-3fe-pg-backend" | ||
if: | | ||
!(build.pull_request.labels includes "ci/main-cron/run-selected") && build.env("CI_STEPS") == null | ||
|| build.pull_request.labels includes "ci/run-e2e-test-other-backends" | ||
|| build.env("CI_STEPS") =~ /(^|,)e2e-test-other-backends?(,|$$)/ | ||
depends_on: | ||
- "build" | ||
- "build-other" | ||
- "docslt" | ||
plugins: | ||
- docker-compose#v5.1.0: | ||
run: pg-mysql-backend-test-env | ||
run: rw-build-env | ||
config: ci/docker-compose.yml | ||
mount-buildkite-agent: true | ||
- ./ci/plugins/upload-failure-logs | ||
timeout_in_minutes: 25 | ||
retry: *auto-retry | ||
|
||
- label: "end-to-end test (mysql backend)" | ||
key: e2e-test-mysql-backend | ||
command: "ci/scripts/e2e-test.sh -p ci-release -m ci-3streaming-2serving-3fe-mysql-backend" | ||
if: | | ||
!(build.pull_request.labels includes "ci/main-cron/run-selected") && build.env("CI_STEPS") == null | ||
|| build.pull_request.labels includes "ci/run-e2e-test-other-backends" | ||
|| build.env("CI_STEPS") =~ /(^|,)e2e-test-other-backends?(,|$$)/ | ||
depends_on: | ||
- "build" | ||
- "build-other" | ||
- "docslt" | ||
plugins: | ||
- docker-compose#v5.1.0: | ||
run: pg-mysql-backend-test-env | ||
config: ci/docker-compose.yml | ||
mount-buildkite-agent: true | ||
- ./ci/plugins/upload-failure-logs | ||
timeout_in_minutes: 30 | ||
retry: *auto-retry | ||
|
||
- label: "end-to-end test for opendal (parallel)" | ||
key: "e2e-test-opendal-parallel" | ||
command: "ci/scripts/e2e-test-parallel-for-opendal.sh -p ci-release" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that
RISEDEV_SQL_ENDPOINT
can be propagated into the container.