refactor(ci): introduce meta backend agnostic e2e tests #19568
Merged
+75
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugenZhao
changed the title
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
BugenZhao
force-pushed
the
bz/ci-adopt-env-sql-backend
branch
from
d27d964 to
5a5255b
Compare
BugenZhao
force-pushed
the
bz/junior-jackal
branch
from
52500b9 to
e802bee
Compare
BugenZhao
force-pushed
the
bz/ci-adopt-env-sql-backend
branch
from
a43d77e to
3a7df77
Compare
BugenZhao
force-pushed
the
bz/junior-jackal
branch
from
e638784 to
be023ee
Compare
BugenZhao
force-pushed
the
bz/ci-adopt-env-sql-backend
branch
from
3a7df77 to
c197fb8
Compare
BugenZhao
changed the title
BugenZhao
changed the title
BugenZhao
force-pushed
the
bz/ci-adopt-env-sql-backend
branch
from
c197fb8 to
f8e36b8
Compare
BugenZhao
requested review from
yezizp2012,
fuyufjh and
xxchan
and removed request for
xxchan and
a team
BugenZhao
force-pushed
the
bz/ci-adopt-env-sql-backend
branch
from
a2f39c6 to
985cb45
Compare
4 tasks
yezizp2012
approved these changes
Nov 27, 2024
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/ci-adopt-env-sql-backend
branch
from
1299e28 to
6f02e68
Compare
BugenZhao
commented
Nov 28, 2024
| docker-compose-common: &docker-compose-common | ||
| config: ci/docker-compose.yml | ||
| mount-buildkite-agent: true | ||
| propagate-environment: true |
There was a problem hiding this comment.
So that RISEDEV_SQL_ENDPOINT can be propagated into the container.
| config: ci/docker-compose.yml | ||
| mount-buildkite-agent: true | ||
| <<: *docker-compose-common | ||
| run: pg-mysql-backend-test-env |
There was a problem hiding this comment.
Can override the entry in *docker-compose-common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
See ideas in #19527.
Reimplement #19152 with the approach introduced in #19560.
Change
meta-backendtoenvforci-3streaming-2serving-3fe, so that we can use this single profile for running e2e tests against 3 backends.Based on above, introduce a build matrix for all 3 backends and their endpoints to merge end-to-end tests against 3 backends in
main-cron.For
pull-request, only MySQL and Postgres are included in the matrix since I still want to make it optional to run tests against them, which was triggered by PR labelci/run-e2e-test-other-backends.Note that this PR does not introduce any new tests but only refactors existing pipelines.
For the future plan, personally I prefer keeping steps lightweight in
pull-request, that is, maintain the status quo that only the basic and common (may also include thesourceone?) end-to-end tests are covered with PG/MySQL backends. Formain-cron, we may extend the coverage as much as possible by simply adding 2 lines for every step.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.