feat(source): support ingesting Avro map type to RisingWave map type #17980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
xxchan
force-pushed
the
08-09-feat_support_ingesting_avro_map_type
branch
4 times, most recently
from
2f8ad1f to
a46e2cc
Compare
xxchan
changed the title
xxchan
force-pushed
the
07-26-feat_support_create_table_with_map_type
branch
from
519cd3d to
83e6410
Compare
xxchan
force-pushed
the
08-09-feat_support_ingesting_avro_map_type
branch
from
a46e2cc to
775d975
Compare
xxchan
force-pushed
the
07-26-feat_support_create_table_with_map_type
branch
from
83e6410 to
34e9829
Compare
xxchan
force-pushed
the
08-09-feat_support_ingesting_avro_map_type
branch
2 times, most recently
from
56f9f43 to
49dca8a
Compare
Base automatically changed from
07-26-feat_support_create_table_with_map_type
to
main
August 13, 2024 07:21
|
@xxchan is it ready for review right now? |
xxchan
force-pushed
the
08-09-feat_support_ingesting_avro_map_type
branch
from
49dca8a to
62a7ea9
Compare
|
@chenzl25 Yes, it's done. Just rebased |
xxchan
force-pushed
the
08-09-feat_support_ingesting_avro_map_type
branch
from
62a7ea9 to
5f1ab1a
Compare
chenzl25
approved these changes
Aug 13, 2024
| @@ -318,6 +318,29 @@ impl<'a> AvroParseOptions<'a> { | |||
| (DataType::Varchar, Value::Uuid(uuid)) => { | |||
| uuid.as_hyphenated().to_string().into_boxed_str().into() | |||
| } | |||
| (DataType::Map(map_type), Value::Map(map)) => { | |||
There was a problem hiding this comment.
LGTM. BTW do you know why we use apache-avro 0.16.0 instead of 0.17.0 here in this crate?
There was a problem hiding this comment.
- We have a few bugfix patches in our fork Contribute patches to upstream avro#6
- And 0.17.0 is just released last week Rebase with upstream 0.17 avro#5
xxchan
force-pushed
the
08-09-feat_support_ingesting_avro_map_type
branch
from
f22c883 to
d3662a6
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Part of #17743
Previously: (#16948)
FORMAT ... ENCODE AVRO (map.handling.mode = 'jsonb')will convert Avro map type to RisingWave jsonb type. Other values ofmap.handling.mode, or unspecified will be rejected.Now
map.handling.mode = 'map'or unspecified will convert it to the native map type.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
As title and description