Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(map): refactor the representation of MapRef to reduce copying #17864

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jul 30, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #17863

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Jul 30, 2024

@xxchan xxchan changed the title refactor(map): refactor the representaion of MapRef perf(map): refactor the representation of MapRef to reduce copying Jul 30, 2024
@xxchan xxchan force-pushed the 07-30-refactor_map_refactor_the_representaion_of_mapref branch from 73e2732 to 05eee81 Compare July 30, 2024 07:48
@xxchan xxchan force-pushed the 07-26-feat_support_create_table_with_map_type branch 4 times, most recently from d757a66 to a563afa Compare August 8, 2024 09:43
@xxchan xxchan closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant