Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): disallow creating new avro sources without schema registry #15256

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Feb 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The current implementation is far from best practice. #12871 Effectively we shall consider it as not supported at all.

Existing sources continue working (in the undesired way). And it is easy to recover the code path in case someone relies on it or we support it in another way later.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Creating sources/table with avro encoding now requires usage of schema registry. The avro definition can no longer come from http[s]:///s3:///file://. The schema.location option shall not be used.

Do NOT document or suggest usage of the option with_deprecated_file_header. It is purely internal to keep the current implementation longer and ease the revert (just in case). If a legit production use case does arise, we shall reimplement it in a more future proof way, for example metadata_preceding_payload = [file | single | confluent_schema_registry | aws_glue_schema_registry | none | fixed_size].

@xiangjinwu xiangjinwu added the user-facing-changes Contains changes that are visible to users label Feb 26, 2024
@xiangjinwu xiangjinwu force-pushed the refactor-source-disallow-avro-file-header branch from a83b334 to 6f88005 Compare February 28, 2024 09:07
@xiangjinwu xiangjinwu force-pushed the refactor-source-disallow-avro-file-header branch from 6f88005 to cf464cd Compare February 28, 2024 09:38
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support forbidding this behavior before it goes too far.

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for removing this function

@xiangjinwu xiangjinwu added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit ef3435e Feb 29, 2024
29 of 30 checks passed
@xiangjinwu xiangjinwu deleted the refactor-source-disallow-avro-file-header branch February 29, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/refactor user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants