refactor(frontend): disallow creating new avro sources without schema registry #15256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The current implementation is far from best practice. #12871 Effectively we shall consider it as not supported at all.
Existing sources continue working (in the undesired way). And it is easy to recover the code path in case someone relies on it or we support it in another way later.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Creating sources/table with avro encoding now requires usage of schema registry. The avro definition can no longer come from
http[s]://
/s3://
/file://
. Theschema.location
option shall not be used.Do NOT document or suggest usage of the option
with_deprecated_file_header
. It is purely internal to keep the current implementation longer and ease the revert (just in case). If a legit production use case does arise, we shall reimplement it in a more future proof way, for examplemetadata_preceding_payload = [file | single | confluent_schema_registry | aws_glue_schema_registry | none | fixed_size]
.