legacy row format syntax

risingwavelabs · Feb 28, 2024 · a83b334 · a83b334
1 parent 87abf29
commit a83b334
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/e2e_test/source/basic/old_row_format_syntax/kafka.slt b/e2e_test/source/basic/old_row_format_syntax/kafka.slt
@@ -155,11 +155,20 @@ create table s8_no_schema_field (
   properties.bootstrap.server = 'message_queue:29092'
 ) ROW FORMAT DEBEZIUM_JSON
 
+statement error without schema registry
+create table s9 with (
+  connector = 'kafka',
+  topic = 'avro_bin',
+  properties.bootstrap.server = 'message_queue:29092',
+  scan.startup.mode = 'earliest'
+) row format avro row schema location 'file:///risingwave/avro-simple-schema.avsc'
+
 statement ok
 create table s9 with (
   connector = 'kafka',
   topic = 'avro_bin',
   properties.bootstrap.server = 'message_queue:29092',
+  with_deprecated_file_header = true,
   scan.startup.mode = 'earliest'
 ) row format avro row schema location 'file:///risingwave/avro-simple-schema.avsc'
 
@@ -168,6 +177,7 @@ create table s10 with (
   connector = 'kafka',
   topic = 'avro_c_bin',
   properties.bootstrap.server = 'message_queue:29092',
+  with_deprecated_file_header = true,
   scan.startup.mode = 'earliest'
 ) row format avro row schema location 'file:///risingwave/avro-complex-schema.avsc'
 
@@ -267,6 +277,7 @@ create source s18 with (
   connector = 'kafka',
   topic = 'avro_c_bin',
   properties.bootstrap.server = 'message_queue:29092',
+  with_deprecated_file_header = true,
   scan.startup.mode = 'earliest'
 ) row format avro row schema location 'file:///risingwave/avro-complex-schema.avsc'
 

diff --git a/src/frontend/src/handler/create_source.rs b/src/frontend/src/handler/create_source.rs
@@ -158,6 +158,9 @@ async fn extract_avro_table_schema(
             && !format_encode_options
                 .get("with_deprecated_file_header")
                 .is_some_and(|v| v == "true")
+            && !with_properties
+                .get("with_deprecated_file_header")
+                .is_some_and(|v| v == "true")
         {
             bail_not_implemented!(issue = 12871, "avro without schema registry");
         }