test: bump sqllogictest & fix backwards-compat-test/e2e-tests #14354
Conversation
xxchan
added
the
ci/run-backwards-compat-tests
|
Indeed. (Why this passed before?) 
|
xxchan
changed the title
|
This is very strange. Q3 failed 
|
xxchan
changed the title
|
Tests passed now... Let's think what happened. |
There was a problem hiding this comment.
@stdrc I just ran gen.py. Is the new file expected?
There was a problem hiding this comment.
I guess that's because you renamed row_number_old.part to row_number_old.slt.part. gen.py only generates for .slt and .slt.part files.
There was a problem hiding this comment.
I don't think it should be renamed. It's leaved here just for reference.
There was a problem hiding this comment.
Original error before my change is this. Can you help fix that?
There was a problem hiding this comment.
Oh, interesting...Seems I did indeed want it to be included...
| statement ok | ||
| flush; |
There was a problem hiding this comment.
If I don't add this flush, q0,1,2 succeed, but q3 failed. Why? 🤡
There was a problem hiding this comment.
If it's ordering of DELETE and INSERT, I don't understand why q0,1,2 succeed
There was a problem hiding this comment.
q0,1,2 seem only depend on bid while q3 also depends on auction
There was a problem hiding this comment.
So what does this imply? 🤔
There was a problem hiding this comment.
IDK, just seems to be explainable if bid table is OK but auction table is not ready
There was a problem hiding this comment.
I can reproduce this locally. It fails sometimes, and person is empty when it fails. bid and auction is fine. 🤡
include ../e2e_test/nexmark/create_tables.slt.part
include ../e2e_test/nexmark/insert_person.slt.part
include ../e2e_test/nexmark/insert_auction.slt.part
include ../e2e_test/nexmark/insert_bid.slt.part
include ../e2e_test/streaming/nexmark/views/q3.slt.part
include ../e2e_test/streaming/nexmark/q3.slt.part
statement ok
DELETE FROM person;
statement ok
DELETE FROM auction;
statement ok
DELETE FROM bid;
include ../e2e_test/nexmark/insert_person.slt.part
include ../e2e_test/nexmark/insert_auction.slt.part
include ../e2e_test/nexmark/insert_bid.slt.part
statement ok
flush;
include ../e2e_test/streaming/nexmark/q3.slt.part
statement ok
drop materialized view nexmark_q3;
include ../e2e_test/nexmark/drop_tables.slt.part
There was a problem hiding this comment.
I had thought that when DML query returns, it will take effect, although not immediately visible. But it seems not correct? 🤔
There was a problem hiding this comment.
After the DML returns, the data is only sent to some internal channels, not handled by the table yet, and there are multiple channels so the order is not known.
| @@ -21,7 +21,7 @@ SET RW_IMPLICIT_FLUSH TO true; | |||
| include ../batch/types/boolean.slt.part | |||
| include ../batch/types/cast.slt.part | |||
| include ../batch/types/date.slt | |||
| include ../batch/types/intercal.slt.part | |||
| statement ok | ||
| flush; |
There was a problem hiding this comment.
q0,1,2 seem only depend on bid while q3 also depends on auction
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
includeempty result risinglightdb/sqllogictest-rs#203 to help found issues. Previously emptyincludes are silently ignored.delete.sltis not included at all.flushed. (defaultbarrier_interval_msis 1000)flushafterinsert, but not afterdelete, nexmark/tpch q0,1,2 passed, but q3 failed. This is a little strange. Is it because there are some moredeletes in the second epoch?Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.