refactor(frontend): simplify bind_columns_from_source #14335
Conversation
xxchan
added
ci/run-main-cron
ci/run-backwards-compat-tests
| stream_source_info.use_schema_registry = protobuf_schema.use_schema_registry; | ||
| stream_source_info.row_schema_location = protobuf_schema.row_schema_location.0.clone(); | ||
| stream_source_info.proto_message_name = protobuf_schema.message_name.0.clone(); | ||
| stream_source_info.key_message_name = | ||
| get_key_message_name(&mut format_encode_options_to_consume); | ||
| stream_source_info.name_strategy = | ||
| name_strategy.unwrap_or(PbSchemaRegistryNameStrategy::Unspecified as i32); | ||
|
|
||
| Some( | ||
| extract_protobuf_table_schema( | ||
| &protobuf_schema, |
There was a problem hiding this comment.
I believe protobuf and avro can also reuse a lot of code, however extract_protobuf_table_schema looks strange and I'm not brave enough to change it in this PR, which contains only equivalent rewrites. 🤡
|
Oops |
|
Why nexmark-backwards-compact failed? It should not be related with this. 🤡 
|
|
For main-cron, only |
|
BTW, Backwards compatibility test failed in PR pipeline, but succeeded in main-cron pipeline... This is so strange. |
- 1000 1001 10465998 2015-07-15 00:00:22.005
+ 1000 1001 10465998 2015-07-15 00:00:22.005
+ 1000 1001 10465998 2015-07-15 00:00:22.005It seems it's |
|
It seems 
|
Oops, I thought it was all about spacing. |
|
I think it's sqllogictest (risinglightdb/sqllogictest-rs#203) or the backwards-compat-tests's problem. But I don't know why only my PR triggered it 🤔 |
|
I've reproduced this #14354 🤣 |
xxchan
removed
the
ci/run-backwards-compat-tests
xxchan
force-pushed
the
xxchan/encouraging-reptile
branch
from
636f1f0 to
29233bb
Compare
Co-authored-by: Bohan Zhang <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
motivation: to make code--
Can review commit by commit, so the correctness might be more easy to verify.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.