chore(deps): Bump apache-avro to 0.16.0 #13523
Conversation
| @@ -15,7 +15,7 @@ normal = ["workspace-hack"] | |||
|
|
|||
| [dependencies] | |||
| anyhow = "1" | |||
| apache-avro = { git = "https://github.com/risingwavelabs/avro", rev = "3c257c1f65e63a80ac44f1cffaf083cdaeab431a", features = [ | |||
| apache-avro = { git = "https://github.com/risingwavelabs/avro", rev = "b251943586e7fe7dd52319fc84f8be47921434aa", features = [ | |||
There was a problem hiding this comment.
| @@ -204,6 +204,7 @@ mod tests { | |||
| let inner_shema_str = r#"{ | |||
| "type": "record", | |||
| "name": "Value", | |||
| "namespace": "dbserver1.inventory.customers", | |||
There was a problem hiding this comment.
This is as reasonable as select v from t being equivalent to select t.v from t. But I have not checked how we are handling namespaces in other places.
| @@ -34,20 +34,19 @@ | |||
| { | |||
| "name": "entrance_date", | |||
| "type": "int", | |||
| "logicalType": "date", | |||
| "default": null | |||
| "logicalType": "date" | |||
There was a problem hiding this comment.
The default value for date field in a struct will be added back when we fully resolve the linked issue.
| "thiserror", | ||
| "typed-builder", | ||
| "typed-builder 0.14.0", | ||
| "uuid", | ||
| "zerocopy", | ||
| ] | ||
|
|
||
| [[package]] | ||
| name = "apache-avro" |
There was a problem hiding this comment.
Why do we have two apache-avro dependencies? Is this expected?
There was a problem hiding this comment.
One is our fork used directly, another is indirect dependency introduced by icelake. This has been the case before this PR, and is expected. We also have multiple versions of some other crates.
Depending on two incompatible versions of the same crate does have some downsides:
- Doubles building time, binary size as well as memory.
- Types defined in one version cannot be passed as arguments to functions defined in another version.
Thus it is better avoided, but not that rare in reality.
There was a problem hiding this comment.
More discussion on having 2 (and even possibly 3) versions of arrow (not avro): #13600 (comment)
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13523 +/- ##
==========================================
+ Coverage 68.39% 68.46% +0.06%
==========================================
Files 1508 1508
Lines 259655 259657 +2
==========================================
+ Hits 177598 177776 +178
+ Misses 82057 81881 -176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Before the bump, our fork was based on main branch on 2023-03-21.
After the bump, the fork is based on release-1.11.3 (crates.io 0.16.0).
Major API change:
Schema::RecordandSchema::Decimalare wrapped inRecordSchemaandDecimalSchema.Note this does not fully resolve #13505 (comment) yet.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.