-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add valuesort, new control result mode and value normalizer #237
Conversation
Signed-off-by: Bruce Ritchie <[email protected]>
Signed-off-by: Bruce Ritchie <[email protected]>
Signed-off-by: Bruce Ritchie <[email protected]>
Signed-off-by: Bruce Ritchie <[email protected]>
Signed-off-by: Bruce Ritchie <[email protected]>
Signed-off-by: Bruce Ritchie <[email protected]>
# Conflicts: # Cargo.lock # Cargo.toml
Signed-off-by: Bruce Ritchie <[email protected]>
@xxchan - any chance this could get a review? |
For context, we are trying to run DataFusion against the entirety of the sqlite test corpus: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks, and happy holiday :)
A general question: does sqlite only do string comparison? What's their behavior of valuesort
on an integer column? Currently we only sort by string, and could order 10
before 2
. If they handle column types other than string, we probably need to add a custom comparator in the future?
query III rowsort | ||
select * from example_sort | ||
---- | ||
1 10 2333 | ||
10 100 2333 | ||
2 20 2333 | ||
2 20 2333 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please also help add a test case for valuesort
? (might require some modifications for FakeDB
)
Thanks, and you too!
From their docs:
So it's the same string comparison as what is done here. |
Signed-off-by: Bruce Ritchie <[email protected]>
just released a new version :) |
Wow -- talk about speedy service with a smile. Thank you @skyzh -- very much apprecaited |
I've adding some functionality to support running the sqlite test suite against another database and this PR is the initial part of that work. This PR adds:
resultmode
of eithervaluewise
orrowwise
(defaulting to the latter)The last point is a breaking API change so I took the liberty to rev the version #. If that isn't desired feel free to revert that portion of this PR.
With this PR I am able to run a slightly cleansed sqlite test suite using the Datafusion sqllogictest harness.