-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete / integrate sqlite sqllogictest test scripts integrattion #13812
Comments
@Omega359 do I have this work described correctly? |
Thanks for putting this together @alamb. Yes, the work is described correctly. CI builds currently are failing because of a clippy warning that I need to look into but otherwise it's good for others to look at. I find that, at least on my machine, running the sqlite tests in 'normal' test mode takes ...forever. I typically run now with --release. Slower to build, faster overall.
if you do not run in release mode you may need to increase the stack size or it'll fail part way in:
|
One issue that I haven't fixed is that some of the sqlite test files are LARGE. In total the files are 763M. I am unsure that we would want them in the main repo ... and I am pretty sure they will fail a CI check with some being > 1MB anyways. Perhaps we need a new datafusion_testing repository where these files would go and be linked into df via .gitmodules |
I think this is a good idea -- or maybe a script that checks out the original sqllite files or something I also think we need to find a way to run it regularly (but likely it can't be on all PRs), see @wiedld from InfluxData expressed interest in helping move this project along. I will let her comment on what she next plans, etc |
Yes, this seems like a perfect thing for a nightly ci run. The thing that is holding me back atm is the sqllogictest-rs changes. Without those in the official repo means either redoing the output of the sqlite results (possible but not particularly easy) or using my fork. I'm hoping to get back to seeing if I can do the rewrite this weekend by comparing the sortmode results during a complete run (with my super hacked up version of sqllogictest-rs) and if they are the same write it out as columnmode. That would mean that the current runner would work. I don't think attempting to pull in the original sqlite files will work as what I am producing is very different from what they have. datafusion_testing repo I think would be best. |
Ok, I believe I'm ready to push a PR for the source code since the sqllogictest-rs folks pushed a release with my changes. I just need a decision on what to do with the actual sqlite .slt files. Do we:
|
yes this is my preferred solution too as it follows an exisitng pre-set pattern |
What are the steps required to have a |
I did some poking around and found on this JIRA: https://issues.apache.org/jira/browse/INFRA-26314?jql=project%20%3D%20INFRA%20AND%20summary%20~%20%22create%20repo%22%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
I submitted a request
It appears it is now available 🎉 : https://github.com/apache/datafusion-testing |
Thank you very much @alamb. I'll work on the PR later today |
Apparently there isn't a way to fork an empty repository in github, or at least I can't seem to find a way so I'm unable to push a PR there for the slt files. Can someone with contributor permissions push a license file to that new repo so that the github UI will allow me to fork it? |
Is your feature request related to a problem or challenge?
Part of #13811
@Omega359 has prototyped integration with the sqlite test suite ❤️
This ticket tracks the remaining work to get this runner merged into datafusion main.
Describe the solution you'd like
I would like:
Bonus points would be some way to regularly run these tests
Describe alternatives you've considered
From #13470 (comment)
Additional context
No response
The text was updated successfully, but these errors were encountered: