Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Boost deprecations #4484

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Resolve Boost deprecations #4484

merged 2 commits into from
Dec 19, 2024

Conversation

randombit
Copy link
Owner

Followup of #4477

@q66
Remove usage of deprecated asio API
2a406be 
These were all finally dropped with boost 1.87, so this fixes
build with boost 1.87.
@randombit randombit requested a review from reneme December 18, 2024 22:11
@coveralls
Copy link

coveralls commented Dec 18, 2024 •
edited
Loading

Coverage Status

coverage: 91.259% (+0.003%) from 91.256%
when pulling 3820f35 on jack/boost-update
into cc835ca on master.

reneme
reneme approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Also, seems to be somewhat urgent now, because brew on macOS seems to have updated boost as well which breaks the build on master.

I'll look into backporting this to release-2.

src/lib/utils/socket/socket.cpp Show resolved Hide resolved
src/lib/utils/socket/socket.cpp Outdated Show resolved Hide resolved
@reneme reneme mentioned this pull request Dec 19, 2024
Merged
@randombit randombit mentioned this pull request Dec 19, 2024
Open
@reneme
Copy link
Collaborator

reneme commented Dec 19, 2024

@randombit I took the liberty to fix the formatting error and squash the "address review comments" commit.

@randombit randombit merged commit 6ea0131 into master Dec 19, 2024
37 checks passed
@randombit randombit deleted the jack/boost-update branch December 19, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneme reneme reneme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@randombit @coveralls @reneme @q66