Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in socket/asio code #4487

Open
randombit opened this issue Dec 19, 2024 · 2 comments
Open

Cleanup in socket/asio code #4487

randombit opened this issue Dec 19, 2024 · 2 comments

Comments

@randombit
Copy link
Owner

          Nit: This could now be calld `dns_result`, `endpoints` or something similar, as it is not technically an iterator anymore.

Originally posted by @reneme in #4484 (comment)

Also could use quite a bit of auto love to hide the various contorted type names.

@reneme
Copy link
Collaborator

reneme commented Dec 19, 2024

On that note we should probably update this guidance on using auto somewhat:

The C++11 ``auto`` keyword is very convenient but only use it when the type
truly is obvious (considering also the potential for unexpected integer
conversions and the like, such as an apparent uint8_t being promoted to an int).

... probably better to extend to something like "... truly obvious or not particularly relevant to reason about the semantics".

@randombit
Copy link
Owner Author

truly obvious or not particularly relevant to reason about the semantics

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants