Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle all "fastresume rejected" cases consistently #17064

Merged
merged 1 commit into from
May 22, 2022
Merged

Handle all "fastresume rejected" cases consistently #17064

merged 1 commit into from
May 22, 2022

Conversation

glassez
Copy link
Member

@glassez glassez commented May 20, 2022 •
edited
Loading

arvidn/libtorrent#6867 is also required to close issues like #15747, #16240 and #16553.

@glassez glassez added the Core label May 20, 2022
@glassez glassez added this to the 4.5.0 milestone May 20, 2022
@glassez glassez requested review from Chocobo1 and a team May 20, 2022 06:50
@Chocobo1
Copy link
Member

Some questions:

  1. Is Handle all "fastresume rejected" cases consistently arvidn/libtorrent#6867 a hard prerequisite for this PR?
  2. Will this PR work well with libtorrnet 1.2.x?

@glassez
Copy link
Member Author

glassez commented May 21, 2022

  1. Is Handle all "fastresume rejected" cases consistently arvidn/libtorrent#6867 a hard prerequisite for this PR?

No.

2. Will this PR work well with libtorrnet 1.2.x?

Yes.
AFAIK, there are no significant differences of how resume data is handled by both 1.2 and 2.0.
Earlier versions accept fastresume data in bencoded form so there can be parsing errors in this place.

@glassez glassez merged commit 8c0cd09 into qbittorrent:master May 22, 2022
@glassez glassez deleted the resume-rejected branch May 22, 2022 04:23
@glassez glassez mentioned this pull request May 24, 2022
Merged
glassez added a commit that referenced this pull request May 25, 2022
@glassez
Pause torrent in all "fastresume rejected" cases
4032393 
PR #17087.
Addition to #17064.
@glassez glassez mentioned this pull request Jul 2, 2022
Open
This was referenced Jul 18, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobo1 Chocobo1 Chocobo1 approved these changes

@thalieht thalieht thalieht approved these changes

Assignees
No one assigned
Labels
Core
Projects
None yet
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@glassez @Chocobo1 @thalieht